-
Notifications
You must be signed in to change notification settings - Fork 12
554 refactoring tool all aspects with references to x #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Yauhenikapl
wants to merge
26
commits into
eclipse-esmf:main
from
bci-oss:554-refactoring-tool-all-aspects-with-references-to-x
Closed
554 refactoring tool all aspects with references to x #599
Yauhenikapl
wants to merge
26
commits into
eclipse-esmf:main
from
bci-oss:554-refactoring-tool-all-aspects-with-references-to-x
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has far-reaching consequences on model loading, model resolving and the APIs that consume loaded models, including model validation.
Since the AspectModelLoader automatically migrates meta model versions - which is necessary to correctly instantiate model elements - running tests for multiple meta model versions does not bring any benefits. This in turn means that test aspect models are not required for all meta model versions but only the current/latest version.
This is is necessary because the number of files in the PR is too large for the reviewdog API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new command for searching using Model in different models.
Fixes #554
Type of change
Checklist:
Additional notes: